enhancement(source): improve clarity of the source send cancelled error message#25686
Open
clementd-dd wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
domain: core
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e83f0390ca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The `source send cancelled` does not immediately convey possible causes and does not provide actionable feedback. Since this error most probably indicates backpressure-related errors, let’s be explicit about it.
clementd-dd
force-pushed
the
clementd-dd/feat-improve-clarity-of-the-source-send-cancelled-error-message
branch
from
e83f039 to
7c6ec8f
Compare
pront
approved these changes
Jun 26, 2026
pront
left a comment
pront
left a comment
Member
There was a problem hiding this comment.
Good improvement.
💭 "pipeline may be overloaded or shutting down."
Ideally we would provide a hint so users can determine this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
source send cancelleddoes not immediately convey possible causes and does not provide actionable feedback. Since this error most probably indicates backpressure-related errors, let’s be explicit about it.Feedback welcome on the actual wording, bikeshed away
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.